K8s: test-gateway addition to tox #8161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Param-29
changed the title
Param-29
changed the title
fixed stack integration tests
rasswanth-s
changed the title
rasswanth-s
approved these changes
Oct 15, 2023
|
Pre-Merge check on staging server, where a gateway could connect to localhost domain, which is not reachable as a proxy client. After the PR -merge, the staging server would be updated, by which , we could check this same test, where we should receive an error during connection itself, where the gateway rejects connection if it is not rechable |
rasswanth-s
reviewed
Oct 16, 2023
| self.connect_to_vpn_self() | ||
| except Exception as e: | ||
| print("Error connecting to VPN: ", e) | ||
| # try: |
There was a problem hiding this comment.
@shubham3121 , for info, I have commented it out, as we are not currently using tailscale, headscale.This was causing very slow startup times, while launching a gateway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: https://github.com/OpenMined/Heartbeat/issues/766
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist