Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding asset uploader when uploading a dataset #8163

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

kiendang
Copy link
Contributor

Should update Dataset.asset_list instead of Dataset.assets which is just a view. The current code only works by accident.

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

.assets is just a view of .asset_list
@madhavajay madhavajay merged commit 8ad6234 into OpenMined:dev Oct 16, 2023
@kiendang kiendang deleted the upload-dataset-asset-contributor branch October 16, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants