Automatically apply fixes to hosts file #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhavajay
reviewed
Oct 18, 2023
- removed bug in sleep command - added build to deploy command
rasswanth-s
reviewed
Oct 26, 2023
rasswanth-s
reviewed
Oct 26, 2023
| return ctypes.windll.shell32.IsUserAnAdmin() == 1 | ||
|
|
||
|
|
||
| def wsl2_disable_auto_hosts() -> None: |
There was a problem hiding this comment.
Q: Yash , could you remind me again, on why we remove this?
rasswanth-s
reviewed
Oct 26, 2023
| changedir = {toxinidir}/packages/grid | ||
| description = Start local Kubernetes registry & cluster with k3d | ||
| changedir = {toxinidir} | ||
| passenv=* |
There was a problem hiding this comment.
Q: Why do we pass in all the environment variables?
rasswanth-s
reviewed
Oct 26, 2023
| [testenv:dev.k8s.info] | ||
| description = Gather info about the localKubernetes cluster | ||
| passenv=HOME, USER | ||
| ignore_errors = True |
There was a problem hiding this comment.
Q: Why do we ignore errors at this place?
rasswanth-s
reviewed
Oct 26, 2023
| description = Destroy both local Kubernetes cluster and registry | ||
| changedir = {toxinidir} | ||
| passenv=HOME, USER | ||
| ignore_errors=True |
There was a problem hiding this comment.
Q: Why do we ignore error at this place?
rasswanth-s
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to https://github.com/OpenMined/Heartbeat/issues/780
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist