Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security - Backend - wolfi container base image with support for rootless user #8179

Merged
merged 23 commits into from
Oct 27, 2023
Merged

Security - Backend - wolfi container base image with support for rootless user #8179

merged 23 commits into from
Oct 27, 2023

Conversation

yashgorana
Copy link
Contributor

@yashgorana yashgorana commented Oct 18, 2023 •
edited
Loading

Description

Part of https://github.com/OpenMined/Heartbeat/issues/822

  • Update backend to work with nonroot linux user
  • Faster build times by caching ML/Pytorch dependencies

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

yashgorana
yashgorana commented Oct 18, 2023
View reviewed changes
packages/syft/setup.cfg Outdated Show resolved Hide resolved
@yashgorana yashgorana self-assigned this Oct 20, 2023
@yashgorana yashgorana changed the title Backend - Security - wolfi container base image with rootless user Security - Backend - wolfi container base image with rootless user Oct 20, 2023
@yashgorana yashgorana changed the title Security - Backend - wolfi container base image with rootless user Security - Backend - wolfi container base image with support for rootless user Oct 26, 2023
madhavajay
madhavajay approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fresh and squeaky clean! Amazing work @yashgorana.
I tested it on arm64 and it works great. I think we can use this for all our containers going forward. ❤️🙏

@madhavajay madhavajay merged commit f4498f8 into dev Oct 27, 2023
30 checks passed
@madhavajay madhavajay deleted the yash/secure-base branch October 27, 2023 01:17
@yashgorana
Copy link
Contributor Author

I missed out on posting the security report:
Screenshot 2023-10-26 233705

@yashgorana yashgorana mentioned this pull request Oct 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhavajay madhavajay madhavajay approved these changes

@shubham3121 shubham3121 Awaiting requested review from shubham3121

@rasswanth-s rasswanth-s Awaiting requested review from rasswanth-s

Assignees

@yashgorana yashgorana

Labels
Purple Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashgorana @madhavajay