Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autouse from fixtures #8188

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

kiendang
Copy link
Contributor

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

Remove autouse=True from fixtures. Looks like none of the fixtures we have actually benefit from autouse and it only slows down the tests. autouse=True is usually only used for side effects, not fixtures that return a value. Also putting autouse=True on fixtures with no dependencies (fixtures that take no arguments) applies that fixtures to every single test in the test suite, a lot of which do not require the fixture at all, slowing down these tests tremendously.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@kiendang kiendang force-pushed the remove-fixture-autouse branch from 8465496 to b2b84bc Compare October 23, 2023 03:13
@kiendang kiendang requested a review from shubham3121 October 23, 2023 07:57
@kiendang kiendang marked this pull request as ready for review October 23, 2023 09:02
@kiendang kiendang force-pushed the remove-fixture-autouse branch 5 times, most recently from e4479ca to e5b265d Compare October 26, 2023 10:25
@kiendang kiendang force-pushed the remove-fixture-autouse branch from e5b265d to 8fd17eb Compare October 26, 2023 15:23
@madhavajay madhavajay merged commit 88974c0 into OpenMined:dev Oct 27, 2023
26 of 27 checks passed
@kiendang kiendang deleted the remove-fixture-autouse branch October 27, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants