Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email Notifications #8455

Merged
merged 115 commits into from
Mar 6, 2024
Merged

Email Notifications #8455

merged 115 commits into from
Mar 6, 2024

Conversation

jcardonnet
Copy link
Contributor

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@jcardonnet jcardonnet requested a review from tcp February 5, 2024 22:21
IonesioJunior and others added 25 commits February 6, 2024 13:58
@IonesioJunior
Merge branch 'dev' into notifier
5cd6fd9
@IonesioJunior
Merge branch 'dev' into notifier
5960001
@IonesioJunior
Enable notifier Service
2bace8b 
- Enable notifier service in node.py
- Fix annotations to allow proper recursive serialization/versioning
- Removed unused Notifier class / Remove its imports from notifier_stash
@IonesioJunior
Implement static init_notifier method and add it during node start wo…
c37262e 
…rkflow
@IonesioJunior
Remove auto creation from notifier stash .get()
2d23fc5
@IonesioJunior
Lint
436ad84
@IonesioJunior
ADD notifier service admin view
890e362
@IonesioJunior
Create notifier_service.turn_on method
97a7272
@IonesioJunior
Update in Notifier base classes
1e4dcb3 
- Rename SMTPServerEmailNotifier -> PostMarkEmailNotifier
- ADD email_token at NotifierSettings
@IonesioJunior
Update/Fix NotifierService.turn_on
ca22509 
- Fix return annotation
- Replace self.stash.set > self.stash.update
@IonesioJunior
ADD checkings for username/password or token during SMTPClient initia…
0facf9c 
…lization
@IonesioJunior
Turn off notifier service
fab6362
@IonesioJunior
ADD check for update results in turn_on service
d267a47
@IonesioJunior
ADD checks for notifier.turn_off update result
69ef589
@IonesioJunior
Merge pull request #8490 from OpenMined/feature/turn_off_notifier
8046670 
5 - ADD Notifier turn off service
@IonesioJunior
Merge branch 'enable_notifier_service' into feature/notifier_settings
4019396
@IonesioJunior
Merge branch 'enable_notifier_service' into add_init_notifier
54dba1d
@IonesioJunior
Merge branch 'enable_notifier_service' into feature/notifier_turn_on
4e8f7ce
@jcardonnet
Merge pull request #8489 from OpenMined/feature/notifier_turn_on
ec9c18b 
4 - ADD Notifier turn_on service
@jcardonnet
Merge pull request #8487 from OpenMined/add_init_notifier
4e1a9ef 
2 - Add init notifier
@jcardonnet
Merge pull request #8488 from OpenMined/feature/notifier_settings
f4de4a0 
3 -  ADD Notifier Settings for Admin view
@jcardonnet
Merge pull request #8485 from OpenMined/enable_notifier_service
287bab3 
1 - Enable notifier Service
@IonesioJunior
Add EMAIL_TOKEN environment variable in hagrid pipeline
5018a3b
@IonesioJunior
Merge branch 'dev' into notifier
2543cd1
@IonesioJunior
Merge branch 'notifier' into feature/hagrid_email_token_flag
4fdf94a
@IonesioJunior IonesioJunior changed the title [WIP] Email Notifications Email Notifications Mar 6, 2024
@IonesioJunior IonesioJunior enabled auto-merge March 6, 2024 19:38
@IonesioJunior IonesioJunior merged commit 3101193 into dev Mar 6, 2024
35 checks passed
@IonesioJunior IonesioJunior deleted the notifier branch March 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiendang kiendang kiendang left review comments

@IonesioJunior IonesioJunior IonesioJunior approved these changes

@tcp tcp Awaiting requested review from tcp

Assignees

@jcardonnet jcardonnet

@IonesioJunior IonesioJunior

Labels
0.8.5 Blue Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcardonnet @kiendang @IonesioJunior @madhavajay @shubham3121