[Refactor] Fixing mypy issues for syft/service/ and syft/util/
#8492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
then call the methods instead of using `assert` since assert statements are removed when compiling Python code to optimized bytecode, causing security issue
khoaguin
changed the title
syft/service/ dirsyft/service/ and syft/util/
kiendang
reviewed
Feb 16, 2024
packages/syft/tests/syft/request/request_multiple_nodes_test.py
Outdated
Show resolved
Hide resolved
kiendang
reviewed
Feb 16, 2024
kiendang
reviewed
Feb 16, 2024
kiendang
reviewed
Feb 16, 2024
- comment out "--warn-unused-ignores" in precommit mypy - small mypy fixes in `service/action` Co-authored-by: Kien Dang <[email protected]>
`base_queue.py` and `queue.py`
Make _func_or_class positional-only in instrument Make noop accept additional arbitrary args and kwargs
khoaguin
force-pushed
the
fix-mypy-issues-service-dir
branch
from
947b2a4 to
beab7ca
Compare
handle cases when context is AuthedServiceContext where node is sure to present Co-authored-by: Shubham Gupta <[email protected]>
shubham3121
requested changes
Feb 28, 2024
| def input_owner_verify_keys(self) -> Optional[List[SyftVerifyKey]]: | ||
| if self.input_policy_init_kwargs is not None: | ||
| return [x.verify_key for x in self.input_policy_init_kwargs.keys()] | ||
| return None |
There was a problem hiding this comment.
we can skip returning None, its the default behaviour with no return types.
…data_cache is None
shubham3121
reviewed
Feb 28, 2024
| @@ -914,7 +915,7 @@ def _syft_try_to_save_to_store(self, obj) -> None: | |||
| ) | |||
|
|
|||
| if api is not None: | |||
| TraceResult.result += [action] | |||
| TraceResult.result += [action] # type: ignore[unreachable] | |||
shubham3121
reviewed
Feb 28, 2024
|
|
||
| if api is not None: | ||
| obj._set_obj_location_(api.node_uid, api.signing_key.verify_key) | ||
| obj._set_obj_location_(api.node_uid, api.signing_key.verify_key) # type: ignore[unreachable] |
to Shubham's recommendations Co-authored-by: Shubham Gupta <[email protected]>
pass type checking instead of returning `SyftError` or raise exceptions
fix typing of object in job stash
- extract input and output init kwargs via getattr instead in syft_function decorator
shubham3121
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mypy issues for
syft/serviceandsyft/utildirectories