-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Veilid Prototype Iteration 2 #8526
Conversation
…packages" This reverts commit f820db1.
add testing notebooks
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
add sample request processing for app call messages
fixed base64 encoding issue for json data updated testing notebook
add transformation for node routes unified veilid constants in veilid_endpoints.py add a test notebook for connections
Added notebook for testing to connect domain to a gateway
packages/grid/helm/syft/templates/veilid/veilid-deployment.yaml
Outdated
Show resolved
Hide resolved
@@ -859,7 +863,7 @@ commands = | |||
bash -c 'NODE_NAME=syft NODE_PORT=${NODE_PORT} && \ | |||
k3d cluster create syft -p "$NODE_PORT:80@loadbalancer" --registry-use k3d-registry.localhost || true \ | |||
k3d cluster start syft' | |||
tox -e dev.k8s.patch.coredns | |||
CLUSTER_NAME=syft tox -e dev.k8s.patch.coredns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you don't need to do this. This command's CLUSTER_NAME will automatically pass to tox -e dev.k8s.patch.coredns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nevermind, the collapsed git diff created some confusion. This is a different command. You can just use the tox -e dev.k8s.start
. It will automatically patch the coredns for you as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will address the same in next PR for refactoring the syft.test.helm tox test 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome Work @rasswanth-s as always 🔥 💯 🥇 🕺🏾 !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is such an epic job @rasswanth-s ! You should feel extremely proud of yourself.
Merging the PR, as the tests are highly flaky, due to which, I have been re-starting the tests from morning |
Description
How has this been tested?
Checklist