Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repr for client.settings #8814

Merged
merged 4 commits into from
May 14, 2024
Merged

Add repr for client.settings #8814

merged 4 commits into from
May 14, 2024

Conversation

jcardonnet
Copy link
Contributor

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@jcardonnet jcardonnet requested a review from IonesioJunior May 14, 2024 15:34
@jcardonnet jcardonnet changed the title [WIP] Add repr for client.settings Add repr for client.settings May 14, 2024
@jcardonnet jcardonnet changed the title Add repr for client.settings [WIP] Add repr for client.settings May 14, 2024
@IonesioJunior IonesioJunior added Blue Team Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor labels May 14, 2024
@jcardonnet jcardonnet changed the title [WIP] Add repr for client.settings Add repr for client.settings May 14, 2024
Copy link
Member

@IonesioJunior IonesioJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IonesioJunior IonesioJunior merged commit 4be8a33 into dev May 14, 2024
27 checks passed
@IonesioJunior IonesioJunior deleted the settings_repr branch May 14, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blue Team Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants