Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node description field on node metadata #8890

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Add node description field on node metadata #8890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f47a4c8
Add node description field on node metadata
jcardonnet Jun 3, 2024
dd02a36
Merge branch 'dev' into node_description
IonesioJunior Jun 3, 2024
c178a90
Merge branch 'dev' into node_description
IonesioJunior Jun 3, 2024
2a2b296
Merge branch 'dev' into node_description
IonesioJunior Jun 11, 2024
7c758a0
Merge branch 'dev' into node_description
jcardonnet Jun 12, 2024
478ef9c
Merge branch 'dev' into node_description
jcardonnet Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/syft/src/syft/service/settings/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ class NodeSettings(SyftObject):
__repr_attrs__ = [
"name",
"organization",
"description",
"deployed_on",
"signup_enabled",
"admin_email",
Expand All @@ -96,7 +97,7 @@ class NodeSettings(SyftObject):
organization: str = "OpenMined"
verify_key: SyftVerifyKey
on_board: bool = True
description: str = "Text"
description: str = "This is the default description for a Domain Node."
node_type: NodeType = NodeType.DOMAIN
signup_enabled: bool
admin_email: str
Expand All @@ -119,6 +120,7 @@ def _repr_html_(self) -> Any:
<p><strong>Id: </strong>{self.id}</p>
<p><strong>Name: </strong>{self.name}</p>
<p><strong>Organization: </strong>{self.organization}</p>
<p><strong>Description: </strong>{self.description}</p>
<p><strong>Deployed on: </strong>{self.deployed_on}</p>
<p><strong>Signup enabled: </strong>{self.signup_enabled}</p>
<p><strong>Admin email: </strong>{self.admin_email}</p>
Expand Down
1 change: 1 addition & 0 deletions packages/syft/src/syft/service/settings/settings_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ def welcome_show(
FONT_CSS=FONT_CSS,
grid_symbol=load_png_base64("small-grid-symbol-logo.png"),
domain_name=context.node.name,
description=context.node.metadata.description,
# node_url='http://testing:8080',
node_type=context.node.metadata.node_type.capitalize(),
node_side_type=node_side_type,
Expand Down
1 change: 1 addition & 0 deletions packages/syft/src/syft/util/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
<h2>Welcome to $domain_name</h2>
<div class="syft-space">
<strong>URL:</strong> $node_url <br />
<strong>Node Description:</strong> $description <br />
<strong>Node Type:</strong> $node_type <br />
<strong>Node Side Type:</strong>$node_side_type<br />
<strong>Syft Version:</strong> $node_version<br />
Expand Down
Loading