Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to enable/disable guest sessions #9119

Merged
merged 19 commits into from
Aug 7, 2024

Conversation

IonesioJunior
Copy link
Member

  • Add a new enable_guest_sessions flag in ServerSettings
  • Update ServerSettingsUpdate to accept enable_guest_sessions parameter
  • Add a check to block guest API calls if enable_guest_sessions is false
  • Create new public routes to recover and reset password
  • Create new client methods to reach /forgot_password and /reset_password endpoints

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

- Add a new enable_guest_sessions flag in ServerSettings
- Update ServerSettingsUpdate to accept enable_guest_sessions parameter
- Add a check to block guest API calls if enable_guest_sessions is false
- Create new public routes to recover and reset password
- Create new client methods to reach /forgot_password and
/reset_password endpoints
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@IrinaMBejan
Copy link
Contributor

Hey Ionesio - can we rename to .allow_guest_sessions? To be uniform with the other sever-side settings.

@@ -914,6 +915,26 @@ def update_self(self, settings: ServerSettings) -> None:
if attr is not Empty:
setattr(self, attr_name, attr)

# NOTE: Some workflows currently expect the settings to be available,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, saw that the tests were failing before because of this. Is there a ticket to look into that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, but it was closed due to the fact that we didn't know how to reproduce: https://github.com/OpenMined/Heartbeat/issues/1264

Copy link
Contributor

@BrendanSchell BrendanSchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! 🚀

@IonesioJunior IonesioJunior merged commit 120ef20 into dev Aug 7, 2024
27 checks passed
@IonesioJunior IonesioJunior deleted the feature/enable_guest_sessions_toggle branch August 7, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants