-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to enable/disable guest sessions #9119
Conversation
- Add a new enable_guest_sessions flag in ServerSettings - Update ServerSettingsUpdate to accept enable_guest_sessions parameter - Add a check to block guest API calls if enable_guest_sessions is false - Create new public routes to recover and reset password - Create new client methods to reach /forgot_password and /reset_password endpoints
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hey Ionesio - can we rename to .allow_guest_sessions? To be uniform with the other sever-side settings. |
This reverts commit be07919.
@@ -914,6 +915,26 @@ def update_self(self, settings: ServerSettings) -> None: | |||
if attr is not Empty: | |||
setattr(self, attr_name, attr) | |||
|
|||
# NOTE: Some workflows currently expect the settings to be available, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, saw that the tests were failing before because of this. Is there a ticket to look into that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, but it was closed due to the fact that we didn't know how to reproduce: https://github.com/OpenMined/Heartbeat/issues/1264
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! 🚀
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist