Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Scaling down k8s worker pool interrupts associated jobs #9278

Closed
wants to merge 11 commits into from

Conversation

BrendanSchell
Copy link
Contributor

Description

  • Updates scaling down in k8s to interrupt jobs on the workers and then delete the workers. Added some testing to notebooks/scenarios/bigquery/001-scale-delete-worker-pools.ipynb.
  • Also didn't seem like job_id was being set on the worker when a job was assigned to it so that was updated which should allow worker.delete to trigger job.kill on the job.
  • Increased scale pool timeout for tests (scaling down to 0 seems to take a little longer now)

Still failing some tests so debugging that.

Closes https://github.com/OpenMined/Heartbeat/issues/1818.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BrendanSchell BrendanSchell force-pushed the bschell/scale-down-k8s-kills-jobs branch from b5773ca to 32dc57f Compare September 12, 2024 14:44
@BrendanSchell
Copy link
Contributor Author

Deprioritized - closing with latest state of code so that it can be picked up at a later time. Job Status not currently being set to interrupted properly on worker_pool.delete in notebook 2 but seems to be with worker_pool.scale(0). Later notebook also times out trying to test out the mock query because the producer dies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant