Feat/add batch emails #9296
Merged
Feat/add batch emails #9296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new email_frequency attribute at Notifier - Add new email_queue attribute at Notifier - Add new send_batches method - Import new SYFT_OBJECT_VERSION_3
- New NotifierSettings version (v3) - New EmailFrequency Object (v1)
Endpoint used to set batch email notification intervals
- ADDs a new set_batch_notification to configure batched email notifications interval - ADD a new aux method to check if it's time to dispatch new notifications based on its EmailFrequency configuration
- Createas a new Email Frequency Object - Change NotifierSettings.email_frequency type hint
- This check uses the custom email frequency configuration to check if a new batch email should be made.
snwagh
approved these changes
Sep 23, 2024
|
Not yet. But working on it right now! 😃 |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
BrendanSchell
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist