Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial email changes #9300

Closed
wants to merge 6 commits into from
Closed

Initial email changes #9300

wants to merge 6 commits into from

Conversation

snwagh
Copy link
Contributor

@snwagh snwagh commented Sep 18, 2024 •
edited
Loading

Adding all the email servers and tests to the sync notebooks

  • low side email server is launched at port 9025, high side on port 9026
  • After the admin on high side approves code and syncs to low side, it is not clear if our system should send a notification to the low side admin and the associated DS. Right now it does not and the tests are incomplete in notebook 040.

Working to close https://github.com/OpenMined/Heartbeat/issues/1833

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@snwagh
Copy link
Contributor Author

snwagh commented Sep 23, 2024

Work moved into this PR.

@snwagh snwagh closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snwagh