Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that users receive approved / reject emails in bigquery L2 notebook #9328

Merged

Conversation

BrendanSchell
Copy link
Contributor

Description

Updates previously commented out check that users receive approval / rejection emails in L2 flow. Updated check to account for user's email notifications potentially being disabled and to make sure they get the right type of email.

Closes https://github.com/OpenMined/Heartbeat/issues/1846.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@IonesioJunior IonesioJunior merged commit 4226ac2 into dev Sep 27, 2024
39 checks passed
@IonesioJunior IonesioJunior deleted the bschell/add-user-emails-received-check-bq-notebooks branch September 27, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants