Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept variable-length batch prompts for Whisper #1457

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Accept variable-length batch prompts for Whisper #1457

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e23c9f8
Accept left offsets in the masked softmax operator
guillaumekln Jul 27, 2023
a11f7c9
Small code reformatting
guillaumekln Jul 28, 2023
4f3f3bb
Accept left offsets when applying position encodings
guillaumekln Jul 28, 2023
51e5cb8
Merge branch 'masked-softmax-left-padding' into left-padding-exp
guillaumekln Jul 28, 2023
a954445
Remove const for attribute
guillaumekln Jul 28, 2023
0acb520
Merge branch 'position-encodings-left-padding' into left-padding-exp
guillaumekln Jul 28, 2023
35fc306
Register left offsets for Whisper prompt
guillaumekln Sep 7, 2023
0dda0d0
Merge branch 'master' into left-padding-exp
guillaumekln Sep 7, 2023
b8c09db
Fix softmax
guillaumekln Sep 7, 2023
e088a67
Remove commented code
guillaumekln Sep 7, 2023
3687a6c
Wrap long line
guillaumekln Sep 7, 2023
9c2c06d
Fix MSVC compilation
guillaumekln Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove const for attribute
  • Loading branch information
@guillaumekln
guillaumekln committed Jul 28, 2023
commit a954445979b6cf5359bb6a45cf18906fe2d32f7b
2 changes: 1 addition & 1 deletion include/ctranslate2/layers/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ namespace ctranslate2 {
protected:
virtual const StorageView& get_position_encoding(dim_t max_time) = 0;
private:
const ops::PositionEncodingsAdd _add_op;
ops::PositionEncodingsAdd _add_op;
};

// Concrete position encoder loading encoding vectors from the model.
Expand Down