Skip to content

Commit

Permalink
Do not record *-default IPP attributes of local CUPS queues
Browse files Browse the repository at this point in the history
Many of the *-default IPP attributes represent properties
already covered by the PPD option defaults which we also record.

I addition, there is also the problematic print-quality-default
attribute. IPP reports print-quality as "draft", "normal", and "high"
while CUPS only accepts "3", "4", and "5" (and NOT "draft", "normal",
and "high") and if an invalid value is supplied, print-quality-default
is set to 0 and as 0 is also invalid, jobs do not get printed. Now,
not touching print-quality-default this does not happen for
cups-browsed's local queues anymore and they reliably print.
  • Loading branch information
tillkamppeter committed Jun 13, 2023
1 parent cb11540 commit dfbc2dd
Showing 1 changed file with 22 additions and 22 deletions.
44 changes: 22 additions & 22 deletions daemon/cups-browsed.c
Original file line number Diff line number Diff line change
Expand Up @@ -5841,28 +5841,28 @@ record_printer_options(const char *printer)
// List of IPP attributes to get recorded
static const char *attrs_to_record[] =
{
"*-default",
"auth-info-required",
//"device-uri",
"job-quota-period",
"job-k-limit",
"job-page-limit",
//"port-monitor",
"printer-error-policy",
"printer-info",
"printer-is-accepting-jobs",
"printer-is-shared",
"printer-geo-location",
"printer-location",
"printer-op-policy",
"printer-organization",
"printer-organizational-unit",
//"printer-state",
"printer-state-message",
"printer-state-reasons",
"requesting-user-name-allowed",
"requesting-user-name-denied",
NULL
//"*-default",
"auth-info-required",
//"device-uri",
"job-quota-period",
"job-k-limit",
"job-page-limit",
//"port-monitor",
"printer-error-policy",
"printer-info",
"printer-is-accepting-jobs",
"printer-is-shared",
"printer-geo-location",
"printer-location",
"printer-op-policy",
"printer-organization",
"printer-organizational-unit",
//"printer-state",
"printer-state-message",
"printer-state-reasons",
"requesting-user-name-allowed",
"requesting-user-name-denied",
NULL
};
const char **ptr;
http_t *conn = NULL;
Expand Down

0 comments on commit dfbc2dd

Please sign in to comment.