PHP 7.4 fixes #22
PHP 7.4 fixes #22
Conversation
ramereth
commented
Jun 11, 2024
ramereth
commented
- Set workdir as a library so this works on EL8
- PHP 7.4 fixes
- Move phpCAS module to composer
Signed-off-by: Lance Albertson <[email protected]>
- Create composer.json and migrate to using smarty 5.3 - Switch to autoloadingn from composer - Various updates to get support for PHP 7.4 Signed-off-by: Lance Albertson <[email protected]>
Signed-off-by: Lance Albertson <[email protected]>
|
I have one question here: Most of the code contained in this repo, especially after your PHP 7.4 migration seem to be copies of third-party libraries (I assume that you did not write ~70000 lines of code in such a short time). Is it really required to carry them in our repo? Can one not just mention them as dependencies in the documentation and tell the user to install them in order to use our code? There are several disadvantages of such code copies:
And even more a maintenance nightmare it gets if you did small changes in the copied library code ... |
|
@tillkamppeter the additional code I added is the output of the composer install so it's vendored libraries. We could in theory move this out of the repository and just keep the composer.json/lock files if you prefer and then do the composer install via our configuration management system on the system itself. Let me know how you'd like to proceed. |
|
@tillkamppeter can we please get this merged soon? |
What are "vendored libraries"? Is it not possible to make foomatic-db-webapp installable on arbitrary servers with a lower amount of copied (and perhaps slightly modified, where it is not clear what got modified) code which this way gets maintained independently at two places (here and at the original place)? Would be the "just keep the composer.json/lock files" way then not be the better way? |
