Skip to content

Commit

Permalink
[Fixes] registry-actions.yml workflow (#31)
Browse files Browse the repository at this point in the history
* Corrected rock path in `registry-actions.yml` & correct env variable (PORT) passed instructions in README

* Fixes typo
  • Loading branch information
rudra-iitm authored Dec 15, 2024
1 parent e39ff6c commit aac3090
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/registry-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ jobs:
- name: Pack with Rockcraft
uses: canonical/craft-actions/rockcraft-pack@main
id: rockcraft
with:
path: rock

- name: Upload Rock Artifact
uses: actions/upload-artifact@v4
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -313,12 +313,12 @@ Then run the following Docker command to run the ps-printer-app image in a conta
sudo docker run --rm -d \
--name ps-printer-app \
--network host \
-e PORT:<port> \
-e PORT=<port> \
openprinting/ps-printer-app:latest
```
- `PORT` is an optional environment variable used to start the printer-app on a specified port. If not provided, it will start on the default port 8000 or, if port 8000 is busy, on 8001 and so on.
- **The container must be started in `--network host` mode** to allow the Printer-Application instance inside the container to access and discover printers available in the local network where the host system is in.
- Alternatively using the internal network of the Docker instance (`-p <port>:8000` instead of `--network host -e PORT:<port>`) only gives access to local printers running on the host system itself.
- Alternatively using the internal network of the Docker instance (`-p <port>:8000` instead of `--network host -e PORT=<port>`) only gives access to local printers running on the host system itself.

### Setting up and running a ps-printer-app container locally

Expand Down Expand Up @@ -360,12 +360,12 @@ sudo rockcraft.skopeo --insecure-policy copy oci-archive:<rock_image> docker-dae
sudo docker run --rm -d \
--name ps-printer-app \
--network host \
-e PORT:<port> \
-e PORT=<port> \
ps-printer-app:latest
```
- `PORT` is an optional environment variable used to start the printer-app on a specified port. If not provided, it will start on the default port 8000 or, if port 8000 is busy, on 8001 and so on.
- **The container must be started in `--network host` mode** to allow the Printer-Application instance inside the container to access and discover printers available in the local network where the host system is in.
- Alternatively using the internal network of the Docker instance (`-p <port>:8000` instead of `--network host -e PORT:<port>`) only gives access to local printers running on the host system itself.
- Alternatively using the internal network of the Docker instance (`-p <port>:8000` instead of `--network host -e PORT=<port>`) only gives access to local printers running on the host system itself.

#### Setting up

Expand Down

0 comments on commit aac3090

Please sign in to comment.