Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed soviet engineer speaking with allied voice set #49

Closed
wants to merge 1 commit into from

Conversation

Mailaender
Copy link
Member

@abcdefg30
Copy link
Member

Sorry, we can't take this at the moment: #1 (comment)

TL;DR: There is no ienssed, iensatc and iensdid, IIRC.

@Mailaender
Copy link
Member Author

That shouldn't be a blocker. If the engine can't find the file, it will only log that. Nothing serious happens.

@abcdefg30
Copy link
Member

But that would mean reverting this after we got an upstream fix like #1 (comment):

Voiced:
    VoiceSet: AlliedEngineer
    FactionVoiceSets:
        allies: AlliedEngineer
        soviets: SovietEngineer

Or like what OpenRA/OpenRA#10422 "proposed".

@Mailaender
Copy link
Member Author

You probably mean OpenRA/OpenRA#10050 which was already rejected.

@GraionDilach
Copy link
Contributor

If the engine can't find the file, it will only log that. Nothing serious happens.

A muted response is IMO serious. But I guess I'm alone with this.

@abcdefg30
Copy link
Member

A muted response is IMO serious. But I guess I'm alone with this.

I think it's a bug that needs fixing too, this at the moment just looks like trading bad yaml with bugs (although it was in principle a good idea to do this).

You probably mean OpenRA/OpenRA#10050 which was already rejected.

I wouldn't say rejected, the author just closed his pr again (even so fast that I didn't recognized what's actually going on there).

@GraionDilach
Copy link
Contributor

This was the reason behind that PR's closure. http://logs.openra.net/?year=2015&month=11&day=21#11:36:32

@Mailaender
Copy link
Member Author

Superseded by #106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants