Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: change time tolerance from 1s to 2s #10141

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

axrolld
Copy link
Contributor

@axrolld axrolld commented Dec 19, 2024

fixes #8951

@axrolld axrolld requested a review from a team as a code owner December 19, 2024 14:56
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (07e13ab) to head (29c445e).
Report is 37 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10141      +/-   ##
==========================================
+ Coverage   79.83%   79.93%   +0.10%     
==========================================
  Files        1054     1057       +3     
  Lines      105529   106302     +773     
  Branches      726      724       -2     
==========================================
+ Hits        84246    84970     +724     
- Misses      21241    21290      +49     
  Partials       42       42              
Flag Coverage Δ
editoast 73.89% <ø> (+0.14%) ⬆️
front 89.19% <100.00%> (+0.05%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clarani
clarani previously approved these changes Dec 19, 2024
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani clarani dismissed their stale review December 19, 2024 15:46

Need testing

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✅

@clarani clarani force-pushed the ard/fix-front-time-olerance branch from 2e87392 to 29c445e Compare December 24, 2024 14:31
@clarani clarani requested a review from a team as a code owner December 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule points marked as not honored even though they're within tolerance
3 participants