Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto before selecting a PR #10157

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Dec 20, 2024

preparing PR #9790

  • rename renderpopup to addpathsteppopup
  • use featureInfoClick from state instead of redux store
  • remove displayPopup property in FeatureInfoClick and allow FeatureInfoClick to be undefined

@theocrsb theocrsb requested review from clarani and Akctarus December 20, 2024 11:17
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (07ef33a) to head (455faf6).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...inschedule/components/ManageTrainSchedule/types.ts 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10157      +/-   ##
==========================================
- Coverage   79.96%   79.94%   -0.02%     
==========================================
  Files        1057     1057              
  Lines      106363   106335      -28     
  Branches      725      724       -1     
==========================================
- Hits        85054    85012      -42     
- Misses      21267    21281      +14     
  Partials       42       42              
Flag Coverage Δ
editoast 73.93% <ø> (-0.05%) ⬇️
front 89.20% <97.72%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb marked this pull request as ready for review December 20, 2024 12:50
@theocrsb theocrsb requested a review from a team as a code owner December 20, 2024 12:50
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@theocrsb theocrsb force-pushed the tce/front/refacto-for-select-op-pr branch from f50e0c6 to 455faf6 Compare December 23, 2024 11:43
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, lgtm

@theocrsb theocrsb added this pull request to the merge queue Dec 23, 2024
Merged via the queue into dev with commit 7096406 Dec 23, 2024
27 checks passed
@theocrsb theocrsb deleted the tce/front/refacto-for-select-op-pr branch December 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants