Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: rename Unauthenticated to Unauthorized, Unauthorized to Forbidden #10191

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Dec 24, 2024

This PR updates the error messages to better align with HTTP status codes. Specifically, it renames the Unauthenticated error to Unauthorized and the Unauthorized error to Forbidden. This change improves clarity and consistency in our error handling.

@hamz2a hamz2a requested a review from a team as a code owner December 24, 2024 12:46
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 24, 2024
@hamz2a hamz2a self-assigned this Dec 24, 2024
@hamz2a hamz2a requested a review from leovalais December 24, 2024 12:48
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Project coverage is 79.93%. Comparing base (41e05a4) to head (63a6612).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/infra/mod.rs 0.00% 14 Missing ⚠️
editoast/src/views/rolling_stock.rs 0.00% 8 Missing ⚠️
editoast/src/views/train_schedule.rs 0.00% 7 Missing ⚠️
editoast/src/views/work_schedules.rs 0.00% 6 Missing ⚠️
editoast/src/views/electrical_profiles.rs 0.00% 5 Missing ⚠️
editoast/src/views/projects.rs 0.00% 5 Missing ⚠️
editoast/src/views/rolling_stock/towed.rs 0.00% 5 Missing ⚠️
editoast/src/views/scenario.rs 0.00% 5 Missing ⚠️
editoast/src/views/scenario/macro_nodes.rs 0.00% 5 Missing ⚠️
editoast/src/views/study.rs 0.00% 5 Missing ⚠️
... and 24 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10191      +/-   ##
==========================================
- Coverage   79.94%   79.93%   -0.01%     
==========================================
  Files        1057     1057              
  Lines      106302   106302              
  Branches      724      724              
==========================================
- Hits        84982    84972      -10     
- Misses      21278    21288      +10     
  Partials       42       42              
Flag Coverage Δ
editoast 73.90% <0.00%> (-0.04%) ⬇️
front 89.19% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

editoast/src/views/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/mod.rs Outdated Show resolved Hide resolved
@leovalais
Copy link
Contributor

leovalais commented Dec 24, 2024

Your commit message is too long: it must be <= 72 characters

@hamz2a hamz2a force-pushed the hai/editoast-rename-error-statuses branch 2 times, most recently from 5ce9cf8 to 821f8c8 Compare December 24, 2024 13:03
@hamz2a hamz2a requested a review from a team as a code owner December 24, 2024 13:03
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 24, 2024
@hamz2a hamz2a force-pushed the hai/editoast-rename-error-statuses branch from 821f8c8 to 63a6612 Compare December 24, 2024 13:07
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@hamz2a hamz2a added this pull request to the merge queue Dec 24, 2024
Merged via the queue into dev with commit 6a105bf Dec 24, 2024
27 checks passed
@hamz2a hamz2a deleted the hai/editoast-rename-error-statuses branch December 24, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants