Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto stdcm op schedule #10192

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 24, 2024

closes #10190

See commits

@clarani clarani requested a review from a team as a code owner December 24, 2024 13:19
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (41e05a4) to head (daac10b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 0.00% 22 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10192      +/-   ##
==========================================
- Coverage   79.94%   79.88%   -0.06%     
==========================================
  Files        1057     1057              
  Lines      106302   106178     -124     
  Branches      724      724              
==========================================
- Hits        84982    84823     -159     
- Misses      21278    21313      +35     
  Partials       42       42              
Flag Coverage Δ
editoast 73.87% <ø> (-0.06%) ⬇️
front 89.15% <75.00%> (-0.05%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch from 3a61621 to 2c31a7d Compare December 24, 2024 13:39
@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch from 2c31a7d to b5f5574 Compare December 24, 2024 14:04
@clarani clarani requested a review from a team as a code owner December 24, 2024 15:08
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I have nothing to say about the code. I'm still testing the application's behavior.
Thanks for the refacto.

@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch from daac10b to b5f5574 Compare December 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: refacto stdcm op schedule
3 participants