Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix projected train icon when ellipsis #10393

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

RomainValls
Copy link
Contributor

close #10300

@RomainValls RomainValls requested a review from a team as a code owner January 15, 2025 14:42
@RomainValls RomainValls requested a review from theocrsb January 15, 2025 14:42
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 15, 2025
@RomainValls RomainValls requested a review from clarani January 15, 2025 14:43
@RomainValls RomainValls force-pushed the rvs/front-fix-ellipsis-in-timetable-train-card branch from cb44087 to ba1b7c0 Compare January 15, 2025 14:45
@RomainValls RomainValls self-assigned this Jan 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (ed45fd3) to head (cae8b78).
Report is 77 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10393      +/-   ##
==========================================
+ Coverage   81.64%   81.77%   +0.13%     
==========================================
  Files        1066     1073       +7     
  Lines      105736   106580     +844     
  Branches      727      731       +4     
==========================================
+ Hits        86330    87160     +830     
- Misses      19365    19381      +16     
+ Partials       41       39       -2     
Flag Coverage Δ
editoast 74.20% <ø> (+0.51%) ⬆️
front 89.34% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I've tried to reproduce the bug and it seems to have been corrected.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

Feel free to resolve my comment once you've fixed it

@RomainValls RomainValls force-pushed the rvs/front-fix-ellipsis-in-timetable-train-card branch from ba1b7c0 to 7ffe572 Compare January 22, 2025 10:37
@RomainValls RomainValls force-pushed the rvs/front-fix-ellipsis-in-timetable-train-card branch from 7ffe572 to cae8b78 Compare January 22, 2025 10:37
@RomainValls RomainValls added this pull request to the merge queue Jan 22, 2025
Merged via the queue into dev with commit 1e35f98 Jan 22, 2025
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-ellipsis-in-timetable-train-card branch January 22, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path projection icon is hidden when the train name is too long
5 participants