Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add ETCS SVL logic to ETCS braking simulator #10402

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Jan 16, 2025

What's left to do:

  • SVL case: compute the minimum between IndicationSvl and IndicationEoa, then maintain speed at dvWarning (4km/h, is minSpeed), then follow indicationEoa, which ends at Eoa, which is the target position (or see how to implement release speed?)
    - compute the minimum envelope between the brakingEnvelopeLOA and brakingEnvelopeEOA (or maybe unneeded and change interface to allow both to be computed one after the other, works as well)

@github-actions github-actions bot added the area:core Work on Core Service label Jan 16, 2025
@Erashin Erashin changed the base branch from dev to alch/core/add_loa_svl_etcs_logic January 16, 2025 10:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (675d279) to head (48c5096).
Report is 1 commits behind head on alch/core/add_loa_svl_etcs_logic.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           alch/core/add_loa_svl_etcs_logic   #10402      +/-   ##
====================================================================
- Coverage                             81.64%   81.59%   -0.06%     
====================================================================
  Files                                  1066     1067       +1     
  Lines                                105735   105535     -200     
  Branches                                727      727              
====================================================================
- Hits                                  86328    86108     -220     
- Misses                                19366    19386      +20     
  Partials                                 41       41              
Flag Coverage Δ
editoast 73.61% <ø> (-0.07%) ⬇️
front 89.30% <ø> (-0.04%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/core/add_loa_svl_etcs_logic branch 5 times, most recently from 5bfa910 to 8350dfe Compare January 16, 2025 11:18
@Erashin Erashin linked an issue Jan 16, 2025 that may be closed by this pull request
@Erashin Erashin changed the title core: add etcs SVL logic core: add ETCS SVL logic to ETCS braking simulator Jan 16, 2025
@Erashin Erashin force-pushed the alch/core/add_loa_svl_etcs_logic branch 6 times, most recently from 5fd6dac to e93a30e Compare January 17, 2025 14:46
Base automatically changed from alch/core/add_loa_svl_etcs_logic to dev January 17, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: ETCS: implement SVL braking curves logic
2 participants