editoast: downgrade reqwest to mitigate timeout issues #7466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multun
force-pushed
the
timeouts-downgrade-reqwest
branch
from
907b2bd to
f1b9e2f
Compare
multun
changed the title
Somewhere between 0.11.27 and 0.12.3, a regression related to timeout handling was introduced. Other users seem to have similar issues: seanmonstar/reqwest#2283 Interestingly enough, this bug report mentions http/2, but the server we're querying only supports http/1.1.
multun
force-pushed
the
timeouts-downgrade-reqwest
branch
from
f1b9e2f to
9a16cf2
Compare
|
I think this bug was introduced in seanmonstar/reqwest#2059, which is the main change behind 0.12.0 |
flomonster
approved these changes
May 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7466 +/- ##
============================================
- Coverage 29.34% 29.34% -0.01%
Complexity 2011 2011
============================================
Files 1177 1177
Lines 145851 145851
Branches 2865 2865
============================================
- Hits 42799 42794 -5
- Misses 101368 101373 +5
Partials 1684 1684
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere between 0.11.27 and 0.12.3, a regression related to timeout handling was introduced. Other users seem to have similar issues: seanmonstar/reqwest#2283 Interestingly enough, this bug report mentions http/2, but the server we're querying only supports http/1.1.