Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse #8795

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Reuse #8795

merged 1 commit into from
Sep 10, 2024

Conversation

EthanPERRUZZA
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.00%. Comparing base (1b14ae3) to head (68d0acb).
Report is 36 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8795      +/-   ##
============================================
+ Coverage     36.92%   37.00%   +0.08%     
+ Complexity     2213     2212       -1     
============================================
  Files          1255     1256       +1     
  Lines        114134   114073      -61     
  Branches       3188     3188              
============================================
+ Hits          42142    42212      +70     
+ Misses        70097    69965     -132     
- Partials       1895     1896       +1     
Flag Coverage Δ
core 74.79% <ø> (+0.04%) ⬆️
editoast 72.13% <ø> (+0.04%) ⬆️
front 14.96% <ø> (+0.03%) ⬆️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EthanPERRUZZA EthanPERRUZZA force-pushed the reuse branch 2 times, most recently from dbe14be to 1c1ed0c Compare September 6, 2024 14:11
@EthanPERRUZZA EthanPERRUZZA marked this pull request as ready for review September 6, 2024 14:43
@EthanPERRUZZA EthanPERRUZZA requested review from a team as code owners September 6, 2024 14:43
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ethan Perruzza <[email protected]>
@ElysaSrc ElysaSrc added this pull request to the merge queue Sep 10, 2024
Merged via the queue into dev with commit 5af604f Sep 10, 2024
24 checks passed
@ElysaSrc ElysaSrc deleted the reuse branch September 10, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants