Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add e2e stdcm tests #9599

Merged
merged 3 commits into from
Nov 20, 2024
Merged

front: add e2e stdcm tests #9599

merged 3 commits into from
Nov 20, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Nov 6, 2024

Closes #9265

@Maymanaf Maymanaf force-pushed the aba/e2e-stdcm-tests branch 2 times, most recently from 85fa764 to 9f409ec Compare November 6, 2024 16:05
@Maymanaf Maymanaf marked this pull request as ready for review November 6, 2024 16:29
@Maymanaf Maymanaf requested a review from a team as a code owner November 6, 2024 16:29
@Yohh Yohh self-requested a review November 6, 2024 16:32
@Maymanaf Maymanaf force-pushed the aba/e2e-stdcm-tests branch 2 times, most recently from 523b85f to 3db814f Compare November 7, 2024 11:47
@Maymanaf
Copy link
Contributor Author

Maymanaf commented Nov 7, 2024

The behavior in CI differs from the local machine (tested with WSL and Ubuntu); the simulation results aren’t the same. I'm currently investigating

@Maymanaf Maymanaf force-pushed the aba/e2e-stdcm-tests branch from 3db814f to 8211a9a Compare November 7, 2024 13:29
@Yohh
Copy link
Contributor

Yohh commented Nov 7, 2024

The behavior in CI differs from the local machine (tested with WSL and Ubuntu); the simulation results aren’t the same. I'm currently investigating

you should wait for #9554 to be merged then rebase, it will change some behaviours for sure

@Khoyo
Copy link
Contributor

Khoyo commented Nov 7, 2024 •
edited
Loading

#9554 shouldn't change any existing behavior, it only adds a script and a new docker image (the ci and running e2e tests outside of docker are completely unaffected)

@Yohh
Copy link
Contributor

Yohh commented Nov 7, 2024

#9554 shouldn't change any existing behavior, it only adds a script and a new docker image (the ci and running e2e tests outside of docker are completely unaffected)

sure, I wasn't saying it about behaviors in the tests themselves

@Maymanaf Maymanaf force-pushed the aba/e2e-stdcm-tests branch from 8211a9a to 6c0df6a Compare November 7, 2024 16:39
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 8, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-stdcm-tests branch 2 times, most recently from e59e079 to 78d60f9 Compare November 13, 2024 16:13
@Maymanaf Maymanaf force-pushed the aba/e2e-stdcm-tests branch from 78d60f9 to 6b16d70 Compare November 18, 2024 12:39
Akctarus
Akctarus reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, I got: Error: Infrastructure state did not reach 'CACHED' within the allotted 3 minutes.

front/src/applications/stdcm/components/StdcmResults/StdcmResultsTable.tsx Outdated Show resolved Hide resolved
SharglutDev
SharglutDev reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this new PR, nice to see some tests for this new stdcm UI. Reviewed in peer with @Akctarus.

Left various comments.

The launch of the tests in debug mode went perfect at the first try and for the second try, the infra won't load and all tests are failing :/

front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/stdcm-page-model.ts Show resolved Hide resolved
front/tests/006-stdcm.spec.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/StdcmHeader.tsx Show resolved Hide resolved
front/tests/005-operational-studies.spec.ts Show resolved Hide resolved
front/tests/utils/api-setup.ts Outdated Show resolved Hide resolved
front/tests/008-train-schedule.spec.ts Outdated Show resolved Hide resolved
front/tests/008-train-schedule.spec.ts Show resolved Hide resolved
front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/stdcm-page-model.ts Show resolved Hide resolved
@SharglutDev
Copy link
Contributor

Also, since I didn't wait for tests to end, I'm stuck with small infra in stdcm when not in debug mode. How can I fix this ?

@Maymanaf
Copy link
Contributor Author

Also, since I didn't wait for tests to end, I'm stuck with small infra in stdcm when not in debug mode. How can I fix this ?

@SharglutDev you should update stdcm env using POST /api/stdcm/search_environment

@Maymanaf
Copy link
Contributor Author

Tested, I got: Error: Infrastructure state did not reach 'CACHED' within the allotted 3 minutes.

@Akctars It's an editoast related problem; you should restart the Docker containers.

@SharglutDev
Copy link
Contributor

Lgtm and tested for me. Great job !

As @Yohh doesn't have his e2e maintainer privilege yet, I'm waiting for his approve to do mine.

Yohh
Yohh approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Akctarus
Akctarus approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM, ty for this PR !

@Maymanaf Maymanaf force-pushed the aba/e2e-stdcm-tests branch from acb3303 to 29fe89e Compare November 20, 2024 14:53
@Maymanaf Maymanaf added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit a83782f Nov 20, 2024
27 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-stdcm-tests branch November 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@Akctarus Akctarus Akctarus approved these changes

@Yohh Yohh Yohh approved these changes

@SarahBellaha SarahBellaha Awaiting requested review from SarahBellaha

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: add e2e tests STDCM
5 participants
@Maymanaf @Yohh @Khoyo @SharglutDev @Akctarus