Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: miscellaneous cleanup (rm /cache_status) #9644

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

bougue-pe
Copy link
Contributor

🔍 please review by commit

@bougue-pe bougue-pe requested review from Khoyo and eckter November 7, 2024 17:45
@bougue-pe bougue-pe requested review from a team as code owners November 7, 2024 17:45
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.86%. Comparing base (c18da7a) to head (d6630dc).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9644      +/-   ##
==========================================
- Coverage   37.87%   37.86%   -0.01%     
==========================================
  Files         990      990              
  Lines       90966    90966              
  Branches     1176     1176              
==========================================
- Hits        34450    34442       -8     
- Misses      56062    56070       +8     
  Partials      454      454              
Flag Coverage Δ
editoast 73.30% <ø> (-0.03%) ⬇️
front 20.10% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bougue-pe bougue-pe force-pushed the peb/core/misc_cleanup branch 2 times, most recently from 2559aaa to 933b96d Compare November 8, 2024 08:24
@bougue-pe bougue-pe force-pushed the peb/core/misc_cleanup branch from 933b96d to b6c1067 Compare November 15, 2024 20:27
after #8599
IDEA suggested a few improvements

Signed-off-by: Pierre-Etienne Bougué <[email protected]>
Let them on API as there is still some use

Signed-off-by: Pierre-Etienne Bougué <[email protected]>
Signed-off-by: Pierre-Etienne Bougué <[email protected]>
@bougue-pe bougue-pe force-pushed the peb/core/misc_cleanup branch from b6c1067 to d6630dc Compare November 18, 2024 19:22
@bougue-pe bougue-pe enabled auto-merge November 18, 2024 19:23
@bougue-pe bougue-pe added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@Khoyo Khoyo added this pull request to the merge queue Nov 19, 2024
Merged via the queue into dev with commit f720fdb Nov 19, 2024
27 checks passed
@Khoyo Khoyo deleted the peb/core/misc_cleanup branch November 19, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants