Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix FromAsCasing warning in dockerfiles #9646

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Nov 7, 2024

Fix the warning generated by docker when from and as casing do not match in dockerfiles, see https://docs.docker.com/reference/build-checks/from-as-casing/

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (a92037a) to head (bee9150).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9646      +/-   ##
============================================
- Coverage     42.51%   42.50%   -0.02%     
  Complexity     2272     2272              
============================================
  Files          1312     1312              
  Lines        105555   105563       +8     
  Branches       3304     3304              
============================================
- Hits          44879    44871       -8     
- Misses        58723    58739      +16     
  Partials       1953     1953              
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 73.74% <ø> (-0.04%) ⬇️
front 18.79% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar
Copy link
Contributor Author

Synar commented Nov 7, 2024

I will try and draft another pr soon to detect docker build --check warnings in the CI

@Synar Synar requested review from Khoyo, emersion and bloussou November 8, 2024 08:39
@Khoyo Khoyo added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit fb3a2b1 Nov 8, 2024
25 checks passed
@Khoyo Khoyo deleted the ali/fix-fromascasing-warning-in-dockerfiles branch November 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants