Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add field weight to op #9775

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Nov 19, 2024

Part of #9746

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (938dd3d) to head (38bc9e4).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9775      +/-   ##
==========================================
- Coverage   79.88%   79.87%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105242   105245       +3     
  Branches      756      756              
==========================================
- Hits        84073    84061      -12     
- Misses      21128    21143      +15     
  Partials       41       41              
Flag Coverage Δ
editoast 73.41% <100.00%> (-0.05%) ⬇️
front 89.36% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <100.00%> (+0.01%) ⬆️
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch 3 times, most recently from 6d42a8a to d2624c3 Compare November 19, 2024 14:22
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Nov 20, 2024
@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch from 35eeb7d to a0c4f3e Compare November 20, 2024 10:42
@younesschrifi younesschrifi marked this pull request as ready for review November 20, 2024 11:03
@younesschrifi younesschrifi requested review from a team as code owners November 20, 2024 11:03
@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch from 7697632 to 82135bb Compare November 20, 2024 11:12
@github-actions github-actions bot removed the area:editoast Work on Editoast Service label Nov 20, 2024
@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch from 82135bb to 7697632 Compare November 20, 2024 11:15
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Nov 20, 2024
@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch 4 times, most recently from 20a1ea4 to e63b929 Compare November 20, 2024 11:30
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tests/

@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch from e63b929 to 33b53f9 Compare November 20, 2024 22:23
@younesschrifi younesschrifi requested a review from a team as a code owner November 21, 2024 23:01
@github-actions github-actions bot added area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services labels Nov 21, 2024
@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch 5 times, most recently from 8b65bf1 to c9468a5 Compare November 21, 2024 23:45
@younesschrifi younesschrifi requested a review from Erashin December 2, 2024 13:57
@github-actions github-actions bot added the area:core Work on Core Service label Dec 2, 2024
@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch 2 times, most recently from 9397c67 to c1ef514 Compare December 2, 2024 14:31
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the PR title fine? Not used to see this format.
Core lgtm otherwise.

Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e tests
You just need to wait for this PR to be merged before

@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch from c1ef514 to ee5854e Compare December 6, 2024 09:26
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi added this pull request to the merge queue Dec 6, 2024
@Khoyo
Copy link
Contributor

Khoyo commented Dec 6, 2024

Is the PR title fine? Not used to see this format.

The default title for multi-commit pr is the name of the branch (instead of the commit title). It's not an ideal title but they don't end up in the git history anyway as we do fast-forward merges only

@woshilapin woshilapin removed this pull request from the merge queue due to a manual request Dec 6, 2024
@younesschrifi younesschrifi added this pull request to the merge queue Dec 6, 2024
@emersion
Copy link
Member

emersion commented Dec 6, 2024

They do end up in release notes though (and in general are not very readable).

@emersion emersion changed the title Yci/add weight field to op editoast: add field weight to op Dec 6, 2024
@younesschrifi
Copy link
Contributor Author

Thank you @emersion for your comment. I'll do better next time :)

@woshilapin woshilapin removed this pull request from the merge queue due to a manual request Dec 6, 2024
@woshilapin woshilapin self-requested a review December 6, 2024 10:05
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I removed this PR from the merge queue.

Sure, most commits are separated which helps for review, but this doesn't make for a reasonable atomic change. So before merging, I believe these should be squashed. For example, changing the schemas in osrd_schemas without changing the corresponding schemas in editoast in the same commit is a mistake to me. That's the reason why we do have a monorepo and change can be done everywhere in one operation. What do you think?

And yes, sure, the title of the PR is not kept around in the git repository, but it's still kept in the Github where all the other PR titles respects some kind of standard formatting. And they end up in the release.

I could also argue that the description of the PR doesn't really help understand the full context (it links to an issue where there is nothing but a title).

Most of the contributions guidelines are here. I know we not always follow them to the line, but here, there are multiple problems and I believe some of them should be addressed (PR title, PR description, non-atomic commits).

Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
@younesschrifi younesschrifi force-pushed the yci/add_weight_field_to_op branch from 4c5afec to 38bc9e4 Compare December 6, 2024 10:19
@woshilapin woshilapin enabled auto-merge December 6, 2024 10:25
@woshilapin woshilapin added this pull request to the merge queue Dec 6, 2024
Merged via the queue into dev with commit 9c34c10 Dec 6, 2024
27 checks passed
@woshilapin woshilapin deleted the yci/add_weight_field_to_op branch December 6, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: update railjson to add field weight in OperationalPoints
10 participants