-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add field weight to op #9775
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9775 +/- ##
==========================================
- Coverage 79.88% 79.87% -0.02%
==========================================
Files 1048 1048
Lines 105242 105245 +3
Branches 756 756
==========================================
- Hits 84073 84061 -12
- Misses 21128 21143 +15
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6d42a8a
to
d2624c3
Compare
35eeb7d
to
a0c4f3e
Compare
7697632
to
82135bb
Compare
82135bb
to
7697632
Compare
20a1ea4
to
e63b929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for tests/
e63b929
to
33b53f9
Compare
8b65bf1
to
c9468a5
Compare
9397c67
to
c1ef514
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the PR title fine? Not used to see this format.
Core lgtm otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for e2e tests
You just need to wait for this PR to be merged before
c1ef514
to
ee5854e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The default title for multi-commit pr is the name of the branch (instead of the commit title). It's not an ideal title but they don't end up in the git history anyway as we do fast-forward merges only |
They do end up in release notes though (and in general are not very readable). |
Thank you @emersion for your comment. I'll do better next time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I removed this PR from the merge queue.
Sure, most commits are separated which helps for review, but this doesn't make for a reasonable atomic change. So before merging, I believe these should be squashed. For example, changing the schemas in osrd_schemas
without changing the corresponding schemas in editoast
in the same commit is a mistake to me. That's the reason why we do have a monorepo and change can be done everywhere in one operation. What do you think?
And yes, sure, the title of the PR is not kept around in the git repository, but it's still kept in the Github where all the other PR titles respects some kind of standard formatting. And they end up in the release.
I could also argue that the description of the PR doesn't really help understand the full context (it links to an issue where there is nothing but a title).
Most of the contributions guidelines are here. I know we not always follow them to the line, but here, there are multiple problems and I believe some of them should be addressed (PR title, PR description, non-atomic commits).
ee5854e
to
4c5afec
Compare
Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
4c5afec
to
38bc9e4
Compare
Part of #9746