Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: cleanup op format functions in scenarios #9899

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Nov 28, 2024

Cleanup changes from #9614

@Synar Synar requested a review from a team as a code owner November 28, 2024 20:03
@Synar Synar requested a review from clarani November 28, 2024 20:03
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 38.17%. Comparing base (83934dc) to head (6e452a5).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/modules/pathfinding/utils.ts 0.00% 3 Missing ⚠️
...ationResult/hooks/useFormattedOperationalPoints.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9899      +/-   ##
==========================================
- Coverage   38.20%   38.17%   -0.03%     
==========================================
  Files         998      997       -1     
  Lines       92197    92191       -6     
  Branches     1192     1192              
==========================================
- Hits        35223    35198      -25     
- Misses      56518    56537      +19     
  Partials      456      456              
Flag Coverage Δ
editoast 73.35% <ø> (-0.05%) ⬇️
front 20.15% <20.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SharglutDev SharglutDev added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@SharglutDev SharglutDev force-pushed the ali/cleanup-op-format-functions-in-scenarios branch from 29d6244 to 6e452a5 Compare December 3, 2024 10:39
@SharglutDev SharglutDev enabled auto-merge December 3, 2024 10:39
@SharglutDev SharglutDev added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit ca2cacf Dec 3, 2024
27 checks passed
@SharglutDev SharglutDev deleted the ali/cleanup-op-format-functions-in-scenarios branch December 3, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants