Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: fix test for engineering allowance possibility #9903

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Nov 29, 2024

Fix some cases of #9023 (still not quite all of them)

The issue is that when computing engineering allowances, we compute the minimum time by computing a slowdown + speedup. Like this:

image

But because of a bug with the intersections, we computed this instead:

image

Which was way too permissive (reaching 0 means we can add infinite time there)

@eckter eckter requested a review from Erashin November 29, 2024 11:00
@eckter eckter requested a review from a team as a code owner November 29, 2024 11:00
@github-actions github-actions bot added the area:core Work on Core Service label Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (d529bf2) to head (e8dabb3).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9903      +/-   ##
==========================================
- Coverage   38.18%   38.16%   -0.03%     
==========================================
  Files         997      997              
  Lines       92195    92195              
  Branches     1192     1192              
==========================================
- Hits        35209    35190      -19     
- Misses      56530    56549      +19     
  Partials      456      456              
Flag Coverage Δ
editoast 73.33% <ø> (-0.07%) ⬇️
front 20.15% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/stdcm-fix-engineering-allowances branch from e91bee6 to 311945c Compare November 29, 2024 11:06
@eckter eckter added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@Erashin Erashin added this pull request to the merge queue Dec 3, 2024
@eckter eckter removed this pull request from the merge queue due to a manual request Dec 3, 2024
@eckter eckter added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@eckter eckter force-pushed the ech/stdcm-fix-engineering-allowances branch from 311945c to 99c18cb Compare December 3, 2024 09:50
@eckter eckter enabled auto-merge December 3, 2024 09:50
@eckter eckter added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@eckter eckter force-pushed the ech/stdcm-fix-engineering-allowances branch from 99c18cb to e8dabb3 Compare December 3, 2024 10:36
@eckter eckter enabled auto-merge December 3, 2024 10:36
@eckter eckter added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit 2f572df Dec 3, 2024
27 checks passed
@eckter eckter deleted the ech/stdcm-fix-engineering-allowances branch December 3, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants