core: amend ertms braking simulator interface #9911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9911 +/- ##
==========================================
- Coverage 38.18% 38.18% -0.01%
==========================================
Files 997 997
Lines 92195 92195
Branches 1192 1192
==========================================
- Hits 35209 35206 -3
- Misses 56530 56533 +3
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
reviewed
Dec 2, 2024
core/src/main/kotlin/fr/sncf/osrd/ertms/etcs/ETCSBrakingSimulator.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/ertms/etcs/ETCSBrakingSimulator.kt
Outdated
Show resolved
Hide resolved
Erashin
force-pushed
the
alch/core/amend-braking-simulator-interface
branch
from
7bf065d to
d8f6129
Compare
eckter
approved these changes
Dec 2, 2024
Signed-off-by: Erashin <[email protected]>
Erashin
force-pushed
the
alch/core/amend-braking-simulator-interface
branch
from
d8f6129 to
2ce0929
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually only want to compute the simulator from the mrsp. What's more, we need to know when to brake + the position of the svl if required. This required the following changes to the interface.