editoast, front: forbid zero-length paths in pathfinding endpoint #9931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:front
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
from
7c7ecdd to
9b5ea0c
Compare
emersion
reviewed
Dec 3, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9931 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 1073 1073
Lines 106584 106601 +17
Branches 731 731
=======================================
+ Hits 87192 87207 +15
- Misses 19353 19355 +2
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emersion
reviewed
Dec 3, 2024
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
6 times, most recently
from
5564da9 to
4cb44f7
Compare
emersion
reviewed
Dec 10, 2024
emersion
reviewed
Dec 10, 2024
|
Note This will conflict with #9924 |
|
Should we authorize pathfinding that has a total length higher than |
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
2 times, most recently
from
858887c to
94aee2d
Compare
SharglutDev
reviewed
Jan 14, 2025
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
from
838a3ea to
df926d1
Compare
SharglutDev
reviewed
Jan 15, 2025
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
from
01850f1 to
30a4ecb
Compare
SharglutDev
reviewed
Jan 21, 2025
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
from
30a4ecb to
5c13dfe
Compare
SharglutDev
approved these changes
Jan 22, 2025
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
2 times, most recently
from
2e294ea to
97db6c4
Compare
- Editoast: treat core pathfinding responses with a length of zero as errors. - Frontend, stdcm: add error notifications when the user enters the same origin and destination. Signed-off-by: Loup Federico <[email protected]>
Pathfinding is prevented when some validity checks don't pass, as for example when the user selects the same origin and destination. The error warning was only updated when pathfinging occurs, causing the user warnings not to be displayed when we could detect before launching the pathfinding that its request would be invalid. Update the warnings independently on whether the pathfinding actually happened so that invalid checks preventing the pathfinding also generate their user warnings. Signed-off-by: Loup Federico <[email protected]>
Sh099078
force-pushed
the
lf/bugfix-pathfinding
branch
from
97db6c4 to
2a2142a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9444
Editoast: immediately return a422 Unprocessable Contenterror at deserialization when the endpointpathfinding/blocksis called with the same origin and destination.pathfinding/blocks: fail in post-processing with a newPathfindingInputError::ZeroLengthPathvariant when core returns zero-length paths.