Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements of AppState management in editoast #9935

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Dec 3, 2024

  • editoast: deprecate DbPool V1 and remove it from the AppState
  • editoast: destructure AppState early in handlers for consistency
  • editoast: fix minor destructuration inconsistencies

TIP
Rapidly reviewable commit by commit

@leovalais leovalais requested a review from a team as a code owner December 3, 2024 16:33
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 3, 2024
@leovalais leovalais force-pushed the lva/appstate-improvements branch from 31957dc to d65ccb0 Compare December 3, 2024 17:01
@leovalais leovalais requested a review from Sh099078 December 3, 2024 18:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.83951% with 44 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (02ccfc8) to head (fd2a3d9).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/timetable.rs 38.88% 11 Missing ⚠️
editoast/src/views/train_schedule/projection.rs 0.00% 8 Missing ⚠️
editoast/src/views/infra/routes.rs 46.15% 7 Missing ⚠️
editoast/src/views/train_schedule.rs 82.85% 6 Missing ⚠️
editoast/src/views/infra/pathfinding.rs 0.00% 5 Missing ⚠️
editoast/src/views/mod.rs 63.63% 4 Missing ⚠️
editoast/src/views/infra/edition.rs 50.00% 1 Missing ⚠️
editoast/src/views/layers.rs 0.00% 1 Missing ⚠️
editoast/src/views/path/properties.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #9935       +/-   ##
===========================================
+ Coverage   38.21%   79.83%   +41.61%     
===========================================
  Files         992     1048       +56     
  Lines       92158   105057    +12899     
  Branches     1186      756      -430     
===========================================
+ Hits        35221    83874    +48653     
+ Misses      56486    21142    -35344     
+ Partials      451       41      -410     
Flag Coverage Δ
editoast 73.36% <72.83%> (-0.04%) ⬇️
front 89.33% <ø> (+69.14%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/appstate-improvements branch from d65ccb0 to 98fbefc Compare December 3, 2024 19:25
@leovalais leovalais force-pushed the lva/appstate-improvements branch from 98fbefc to a1b7040 Compare December 4, 2024 07:41
editoast/src/views/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable.rs Outdated Show resolved Hide resolved
@leovalais leovalais force-pushed the lva/appstate-improvements branch from a1b7040 to 6968585 Compare December 4, 2024 14:05
@leovalais leovalais enabled auto-merge December 4, 2024 14:12
@leovalais
Copy link
Contributor Author

Thanks @woshilapin for the review! I'll let you resolve the conversations if the changes are ok with you. (I implemented FromRef for Arc<CoreClient> instead as it's clone isn't as cheap as cloning an Arc.)

@leovalais leovalais added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit bbc9728 Dec 4, 2024
27 checks passed
@leovalais leovalais deleted the lva/appstate-improvements branch December 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants