-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements of AppState management in editoast #9935
Conversation
leovalais
commented
Dec 3, 2024
•
edited
Loading
edited
- editoast: deprecate DbPool V1 and remove it from the AppState
- editoast: destructure AppState early in handlers for consistency
- editoast: fix minor destructuration inconsistencies
31957dc
to
d65ccb0
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9935 +/- ##
===========================================
+ Coverage 38.21% 79.83% +41.61%
===========================================
Files 992 1048 +56
Lines 92158 105057 +12899
Branches 1186 756 -430
===========================================
+ Hits 35221 83874 +48653
+ Misses 56486 21142 -35344
+ Partials 451 41 -410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Leo Valais <[email protected]>
d65ccb0
to
98fbefc
Compare
Signed-off-by: Leo Valais <[email protected]>
98fbefc
to
a1b7040
Compare
Signed-off-by: Leo Valais <[email protected]>
a1b7040
to
6968585
Compare
Signed-off-by: Leo Valais <[email protected]>
Thanks @woshilapin for the review! I'll let you resolve the conversations if the changes are ok with you. (I implemented |