front: set default tolerances in the store #9977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clara Ni <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9977 +/- ##
==========================================
- Coverage 79.87% 79.87% -0.01%
==========================================
Files 1048 1048
Lines 105232 105246 +14
Branches 756 756
==========================================
+ Hits 84057 84063 +6
- Misses 21134 21142 +8
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
theocrsb
requested changes
Dec 6, 2024
After cleaning the local storage, it works well for me |
clarani
added a commit
that referenced
this pull request
Dec 11, 2024
tolerances are stored in the store and in the local storage. For some users, this field is still undefined in their local storage. However, since #9977, we assume that tolerances can not be undefined, which is not true if the users have not reset their store (=clean their cookies) or manullaly filled it. To prevent the app from crashing when a user without tolerances opens the stdcm page, I revert the changes in StdcmOrigin and StdcmDestination for now. Signed-off-by: Clara Ni <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
tolerances are stored in the store and in the local storage. For some users, this field is still undefined in their local storage. However, since #9977, we assume that tolerances can not be undefined, which is not true if the users have not reset their store (=clean their cookies) or manullaly filled it. To prevent the app from crashing when a user without tolerances opens the stdcm page, I revert the changes in StdcmOrigin and StdcmDestination for now. Signed-off-by: Clara Ni <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
tolerances are stored in the store and in the local storage. For some users, this field is still undefined in their local storage. However, since #9977, we assume that tolerances can not be undefined, which is not true if the users have not reset their store (=clean their cookies) or manullaly filled it. To prevent the app from crashing when a user without tolerances opens the stdcm page, I revert the changes in StdcmOrigin and StdcmDestination for now. Signed-off-by: Clara Ni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9803