Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: change stdcm environment date type #9985

Merged

Conversation

SarahBellaha
Copy link
Contributor

Closes #9974

@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (6a105bf) to head (d5e01b6).
Report is 10 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9985      +/-   ##
==========================================
+ Coverage   79.93%   81.42%   +1.48%     
==========================================
  Files        1057     1057              
  Lines      106302   104212    -2090     
  Branches      724      720       -4     
==========================================
- Hits        84977    84855     -122     
+ Misses      21283    19315    -1968     
  Partials       42       42              
Flag Coverage Δ
editoast 73.57% <100.00%> (-0.35%) ⬇️
front 89.18% <100.00%> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha force-pushed the sba/editoast/change-stdcm-search-environment-date-type branch 2 times, most recently from 59eb5d4 to cf4482e Compare December 16, 2024 13:33
@SarahBellaha SarahBellaha marked this pull request as ready for review December 16, 2024 13:33
@SarahBellaha SarahBellaha requested a review from a team as a code owner December 16, 2024 13:33
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, this really improves the entire OSRD stack!

editoast/src/models/stdcm_search_environment.rs Outdated Show resolved Hide resolved
@SarahBellaha SarahBellaha requested review from a team as code owners December 17, 2024 16:36
@SarahBellaha SarahBellaha force-pushed the sba/editoast/change-stdcm-search-environment-date-type branch from 5880790 to a4621b4 Compare December 17, 2024 16:45
@SarahBellaha SarahBellaha removed request for a team December 17, 2024 16:46
@SarahBellaha SarahBellaha force-pushed the sba/editoast/change-stdcm-search-environment-date-type branch from 98c105b to a918e22 Compare December 18, 2024 14:36
@SarahBellaha SarahBellaha force-pushed the sba/editoast/change-stdcm-search-environment-date-type branch from a918e22 to 10de4da Compare December 30, 2024 10:11
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 30, 2024
@SarahBellaha SarahBellaha requested review from Yohh and clarani January 2, 2025 09:36
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@SarahBellaha SarahBellaha added this pull request to the merge queue Jan 2, 2025
Merged via the queue into dev with commit 1e79fc2 Jan 2, 2025
27 checks passed
@SarahBellaha SarahBellaha deleted the sba/editoast/change-stdcm-search-environment-date-type branch January 2, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: search environment's dates have no timezone
5 participants