Be able to delete temporary files on a different mount point #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are able to create files on a different mount point, but not delete them. This is at most inconvenient, except when running tests. A lot of the tests just checks of anything has been written to 'stderr', if it has, the test fail. Since we are not allowed to delete files, the parent directory is not empty when it is supposed to be removed, and an error message is printed to 'stderr'. If we are able to create files, we should be allowed to delete them as well.
|
/packit rebuild-failed |
evgenyz
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are able to create files on a different mount point, but not delete them. This is at most inconvenient, except when running tests.
A lot of the tests just checks of anything has been written to
stderr, if it has, the test fail. Since we are not allowed to delete files, the parent directory is not empty when it is supposed to be removed, and an error message is printed tostderr.If we are able to create files, we should be allowed to delete them as well.