-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init start support gatewayconfig #231
Merged
0xsarvesh
merged 16 commits into
OpenST:master
from
gulshanvasnani:init_start_support_gatewayconfig
Oct 23, 2019
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
755112e
Changes done to use token config in facilitator init
gulshanvasnani 8279ecb
Merge branch 'common_interface_mosaic_token' into init_start_support_…
gulshanvasnani 0e0ee78
Added gatewayconfig option in facilitator init
gulshanvasnani f9de283
Merge branch 'common_interface_mosaic_token' into init_start_support_…
gulshanvasnani 0264766
Merge remote-tracking branch 'upstream/master' into init_start_suppor…
gulshanvasnani f497842
Added gateway config option in facilitator-start command; Unit test c…
gulshanvasnani c69e555
Reverted changes
gulshanvasnani af25fd9
Removed console
gulshanvasnani d57c7b8
Added validation so that together gateway config and mosaic-config is…
gulshanvasnani 939b7c4
Documentation changes
gulshanvasnani e29cef4
Added validation and updated readme
gulshanvasnani dcd07f9
Fixed failing test case
gulshanvasnani fbeacbf
Added FacilitatorInit class, ConfiyType enum, unit test cases
gulshanvasnani e9b7336
Updated readme; Fixed test cases
gulshanvasnani f681282
Updated gateway-config short option; Added types of stub methods
gulshanvasnani a89317c
Merge remote-tracking branch 'upstream/master' into init_start_suppor…
gulshanvasnani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should check if mosaic config
exists
. Because from chain with return blank object if it doesn't exist.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added suggested approach.
But i think, fromChain should throw error when path is not present.
It will be aligned to what we do in fromFile method.
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created ticket to align fromChain and fromFile methods OpenST/mosaic-chains#196