Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement motion_change_recommendation creation in motion forward #2549

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Aug 2, 2024

Closes #2519

TODO:

  • Test with less attributes filled
  • Test with no change recommendations in db, but flag set
  • Test with change recos in db but no flag set
  • Test with amendments

@luisa-beerboom luisa-beerboom added this to the 4.2 milestone Aug 2, 2024
@luisa-beerboom luisa-beerboom self-assigned this Aug 2, 2024
@luisa-beerboom luisa-beerboom marked this pull request as ready for review August 5, 2024 08:39
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update documentation

@luisa-beerboom
Copy link
Member Author

Please update documentation

Done

Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good now

@Elblinator Elblinator linked an issue Aug 6, 2024 that may be closed by this pull request
},
)
assert reco["creation_time"] > 0
reco = self.assert_model_exists(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reco isn't used after this line.

},
)
assert reco["creation_time"] > 0
reco = self.assert_model_exists(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reco isn't used after this line.

@hjanott hjanott assigned luisa-beerboom and unassigned hjanott Aug 8, 2024
@luisa-beerboom luisa-beerboom merged commit dc578b2 into OpenSlides:feature/motion-forward Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance motion.create_forwarded part 2
3 participants