2742 kill session user set inactive #2752
Open
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjanott
added
the
enhancement
reiterl
requested changes
Dec 2, 2024
Comment on lines
143
to
147
| if instance.get("is_active"): | ||
| if not user.get("is_active"): | ||
| self.check_limit_of_user(1) | ||
| elif user.get("is_active"): | ||
| self.auth.clear_sessions_by_user_id(instance["id"]) |
There was a problem hiding this comment.
"If is_action is not in payload (instance) and user is_active, then clear session", this doesn't seem right.
The is_active payload is optional as far as I know.
There was a problem hiding this comment.
That should be repaired now.
luisa-beerboom
approved these changes
Dec 3, 2024
Comment on lines
+2424
to
+2455
| def test_update_clear_user_sessions(self) -> None: | ||
| self.create_meeting() | ||
| self.set_models( | ||
| { | ||
| "user/2": { | ||
| "is_active": True, | ||
| "default_password": "no_password", | ||
| "username": "user2", | ||
| "password": self.auth.hash("no_password"), | ||
| }, | ||
| } | ||
| ) | ||
| self.set_user_groups(2, [2]) | ||
| self.login(2) | ||
| response = self.request( | ||
| "user.update", | ||
| { | ||
| "id": 2, | ||
| }, | ||
| ) | ||
| self.assert_status_code(response, 200) | ||
| self.assert_logged_in() | ||
| response = self.request( | ||
| "user.update", | ||
| { | ||
| "id": 2, | ||
| "is_active": False, | ||
| }, | ||
| ) | ||
| self.assert_status_code(response, 200) | ||
| self.assert_model_exists("user/2", {"is_active": False}) | ||
| self.assert_logged_out() |
There was a problem hiding this comment.
It would probably be better to just add the upper half of this test to another test, to ensure that we can differentiate what exactly is failing more easily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2742
Waiting OpenSlides/openslides-auth-service#590