Ignore assignment candidates already on list of speakers on phase to voting #2768
Conversation
| @@ -63,6 +81,8 @@ def update_instance(self, instance: dict[str, Any]) -> dict[str, Any]: | |||
| ) | |||
| ] | |||
| )["assignment_candidate"].values() | |||
| if (meeting_user_id := candidate["meeting_user_id"]) | |||
There was a problem hiding this comment.
Why use the walross notation here ? I would prefer using candidate... twice.
There was a problem hiding this comment.
Changed that but the if statement will still be over two lines.
| self.prepare_voting_phase_test(3) | ||
| self.request("speaker.create", {"meeting_user_id": 1, "list_of_speakers_id": 1}) | ||
| response = self.request( |
There was a problem hiding this comment.
Both must be checked: Putting on list and putting not on list, because already there, I see one test, hmm...
There was a problem hiding this comment.
Wrote that additional test.
| [ | ||
| GetManyRequest( | ||
| "speaker", | ||
| list_of_speakers["speaker_ids"], |
There was a problem hiding this comment.
Are you sure, that los always contains a speaker_ids and that it is not empty? Please write a test with an empty los and try it.
There was a problem hiding this comment.
Good point. I fixed that.
| self.assert_model_exists( | ||
| f"speaker/{id_}", | ||
| {"list_of_speakers_id": 1, "meeting_user_id": id_, "meeting_id": 1}, | ||
| ) |
There was a problem hiding this comment.
Mmh, I think you want to check the los here too. That it just have three speakers in it. Also check the los in the test below.
Closes #2761