-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VoteWeight documentation and translated search for detail poll view #4379
base: main
Are you sure you want to change the base?
Conversation
…rt and added search for translated vote values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vote weight is displayed mostly as expected and the translation is working fine.
There is an unclear case where the wanted behaviour is not completely clear:
If a motion poll was nominal and then was anonymized:
Status quo: The type of the poll stays nominal but the single votes look like the single votes from a non-nominal poll.
New behaviour with vote weight: the vote weight is then still displayed in the entitled users list and the vote weight is exported in the pdf-export
Possibilities for the vote weight:
A) The vote weight could be hidden and single votes and entitled users list would lookl like the lists from non-nominal votes
B) The vote weight could be displayed and be aligned with the type from the poll (if that is the case then there is another CR:
If a nominal vote is anonymised and then the page is reloaded then there are Errors running through the console e.g.
participant-controller.service.ts:113 ERROR TypeError: Cannot read properties of undefined (reading 'map')
@MSoeb Do you want A) or B) to happen or is there a third option which is preferred
@Input() | ||
public parent: BasePollDetailComponent<PollContentObject, PollService>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer a boolean property displayVoteWeight
client/src/app/site/pages/meetings/modules/poll/base/base-poll-detail.component.ts
Outdated
Show resolved
Hide resolved
@@ -35,7 +35,13 @@ export class MotionPollDetailComponent extends BasePollDetailComponent<ViewMotio | |||
} | |||
|
|||
protected createVotesData(): BaseVoteData[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of extending BaseVoteData
(which is also used in other places) add a new type specific for this use case.
protected createVotesData(): BaseVoteData[] { | |
protected createVotesData(): BaseVoteData[] { |
After a discussion it was decisded that the vote weight should be displayed regardless of "no minal"/"non-nominal" |
…ed users list and handle anonymisedvotes list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the vote weight (in exactly the same manner) to the election-polls
Closes #4289
Closes #4301