Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use autoupdate for mediafile restrictions #125

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Use autoupdate for mediafile restrictions #125

merged 4 commits into from
Jul 31, 2024

Conversation

bastianjoel
Copy link
Member

resolves #124

@bastianjoel bastianjoel added the enhancement General enhancement which is neither bug nor feature label Jul 30, 2024
@bastianjoel bastianjoel added this to the 4.2 milestone Jul 30, 2024
@bastianjoel bastianjoel force-pushed the 124-autoupdate-restrictor branch from 54c2fce to 105e4cf Compare July 30, 2024 12:39
@bastianjoel bastianjoel force-pushed the 124-autoupdate-restrictor branch from e233639 to bb13781 Compare July 30, 2024 13:06
@bastianjoel bastianjoel force-pushed the 124-autoupdate-restrictor branch from bb13781 to 7109d30 Compare July 30, 2024 13:49
@bastianjoel bastianjoel requested a review from Elblinator July 30, 2024 13:53
@bastianjoel
Copy link
Member Author

@Elblinator Check if files still get correctly restricted.

luisa-beerboom
luisa-beerboom reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about the inner workings of the media service, but code-style-wise this looks fine

@luisa-beerboom luisa-beerboom removed their assignment Jul 31, 2024
@bastianjoel bastianjoel requested a review from hjanott July 31, 2024 09:28
peb-adr
peb-adr approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@peb-adr peb-adr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.
Implemented as discussed.

@Elblinator Elblinator removed their assignment Jul 31, 2024
@bastianjoel bastianjoel merged commit 96c8f72 into OpenSlides:main Jul 31, 2024
3 checks passed
@bastianjoel bastianjoel deleted the 124-autoupdate-restrictor branch July 31, 2024 12:29
@luisa-beerboom luisa-beerboom mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisa-beerboom luisa-beerboom luisa-beerboom left review comments

@Elblinator Elblinator Elblinator approved these changes

@peb-adr peb-adr peb-adr approved these changes

@hjanott hjanott Awaiting requested review from hjanott

Assignees

@hjanott hjanott

Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Mediaservice use autoupdate for mediafile permission check
5 participants
@bastianjoel @peb-adr @Elblinator @luisa-beerboom @hjanott