Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate relational schema #17

Conversation

r-peschke
Copy link
Member

@r-peschke r-peschke commented Feb 7, 2024

As agreed let us merge this PR to the feature-branch

@r-peschke r-peschke added this to the 4.2 milestone Feb 7, 2024
@r-peschke r-peschke self-assigned this Feb 7, 2024
@jsangmeister jsangmeister changed the title generate relational schema Generate relational schema Feb 8, 2024
@jsangmeister jsangmeister linked an issue Feb 20, 2024 that may be closed by this pull request
10 tasks
@jsangmeister jsangmeister changed the base branch from main to feature/relational-db March 12, 2024 08:44
Copy link
Contributor

@jsangmeister jsangmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typos or clarifications. The concept itself looks good. I'm missing a list of required attributes for reach relation type, e.g.:

  • 1:1 must always contain a reference on one side and a sql on the other
  • similar rules for 1:n and m:n

(just an example because I don't know the actual rules yet)

This can then be validated if we want via the to attributes, which is another reason why I would like to keep them.

models.yml Outdated Show resolved Hide resolved
models.yml Outdated Show resolved Hide resolved
models.yml Outdated Show resolved Hide resolved
models.yml Outdated Show resolved Hide resolved
models.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
dev/src/generate_sql_schema.py Outdated Show resolved Hide resolved
dev/src/generate_sql_schema.py Outdated Show resolved Hide resolved
@r-peschke
Copy link
Member Author

Small typos or clarifications. The concept itself looks good. I'm missing a list of required attributes for reach relation type, e.g.:

* 1:1 must always contain a `reference` on one side and a `sql` on the other

* similar rules for 1:n and m:n

(just an example because I don't know the actual rules yet)

This can then be validated if we want via the to attributes, which is another reason why I would like to keep them.

This is documented in models.yml as list of implemented from-to-rules.

@r-peschke r-peschke marked this pull request as ready for review April 4, 2024 15:08
@r-peschke r-peschke removed their assignment Apr 4, 2024
@r-peschke r-peschke merged commit 1d0c410 into OpenSlides:feature/relational-db Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate schema.sql from models.yml for relational database
2 participants