Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation problem #3

Open
tbaudier opened this issue Oct 13, 2016 · 4 comments
Open

Compilation problem #3

tbaudier opened this issue Oct 13, 2016 · 4 comments
Labels

Comments

@tbaudier
Copy link
Contributor

I have a problem to compile syd with the last commit:
07/10/2016 correctly closed version
756b1a2

The problem comes from the link with Eigen and Ceres.
I finally succeed to compile it using the flag -fopenmp in CMAKE_CXX_FLAGS (with ccmake)
(ref: https://forums.freebsd.org/threads/9153/).

I start to find the problematic commit.

@tbaudier tbaudier added the bug label Oct 13, 2016
@tbaudier
Copy link
Contributor Author

tbaudier commented Oct 13, 2016

The problem occurs here:
The commit 216ca49 succeeds to compile.
The following commit 4fe0490 fails.

It seems there is a problem in:

  • src/std_db/sydTimeIntegratedActivityImageBuilder.h
    l68. syd::TimeIntegratedActivityImageFilter filter_;
    l69. syd::TimeIntegratedActivityFitOptions options_;
  • src/std_db/sydInsertTimeIntegratedActivityImage.cxx
    l66. syd::TimeIntegratedActivityFitOptions options;

But the same line works in:

  • src/core/sydTimeIntegratedActivityImageFilter.h
    l79. syd::TimeIntegratedActivityFitOptions options_;

@tbaudier
Copy link
Contributor Author

tbaudier commented Oct 13, 2016

If I add into CMakeLists.txt the tag -fopenmp it works:
l120->l126

This is required on some system (linux) to allow linking

if("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "x86_64")
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fPIC" )
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fPIC" )
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC" )
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fopenmp" )
endif("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "x86_64")

Is it a problem for x86_64 Linux computer ?

@tbaudier
Copy link
Contributor Author

Modified with commit:
59e9fe6

@tbaudier
Copy link
Contributor Author

There is a tag in the Ceres's CMakeLists.txt: OPENMP
For me it's ON but We have to verify if it can be turn OFF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant