Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub registry #314

Merged
merged 8 commits into from
Mar 24, 2023
Merged

GitHub registry #314

merged 8 commits into from
Mar 24, 2023

Conversation

PhilWun
Copy link
Contributor

@PhilWun PhilWun commented Mar 23, 2023

This PR

  • replaces Docker Hub with the GitHub registry in the GitHub workflow and updates the used GitHub actions
  • temporarily disables the PlanQK Service integration test as it's not compatible anymore with the platforms' authentication

Needed for OpenTOSCA/opentosca-docker#57

@PhilWun PhilWun requested a review from wederbn March 23, 2023 16:18
@wederbn wederbn requested a review from zimmerml March 24, 2023 08:44
@wederbn
Copy link
Member

wederbn commented Mar 24, 2023

Could you please check why the build fails?

@PhilWun
Copy link
Contributor Author

PhilWun commented Mar 24, 2023

I think the GitHub secret that contains the API token for codacy is empty because this is a PR from a fork:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

@wederbn
Copy link
Member

wederbn commented Mar 24, 2023

Could you move it to a branch here then? Or any other idea?

@PhilWun PhilWun changed the base branch from master to feature/github-registry March 24, 2023 10:00
@PhilWun
Copy link
Contributor Author

PhilWun commented Mar 24, 2023

I changed the base branch of this PR to a new branch. We can merge it in this new branch, then I will make a new PR.

@wederbn wederbn merged commit e6b83de into OpenTOSCA:feature/github-registry Mar 24, 2023
wederbn pushed a commit that referenced this pull request Mar 24, 2023
* replace docker hub with GitHub registry

* fix yml syntax

* disable PlanQK service integration test

* fix condition, temporarily disable integration tests

* fix empty list

* temporarily remove test job

* reenable integration tests

* replace every mention of Dockerhub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants