Add unit tests for Registry in Agent (#320)

Signed-off-by: Konstantin Ilichev <[email protected]>
OpenVisualCloud · Feb 11, 2025 · f95c0fb · f95c0fb
1 parent 2052f16
commit f95c0fb
Show file tree

Hide file tree

Showing 11 changed files with 1,205 additions and 32 deletions.
diff --git a/.github/configs/super-linter/.golangci.yml b/.github/configs/super-linter/.golangci.yml
@@ -35,3 +35,5 @@ linters-settings:
   gocyclo:
     # minimal code complexity to report, 30 by default
     min-complexity: 15
+run:
+  tests: false
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -62,7 +62,7 @@ jobs:
       packages: read
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      DISABLE_ERRORS: "false"
+      DISABLE_ERRORS: "true"
       BASH_SEVERITY: "warning"
     steps:
       - name: "super-linter: Harden Runner"
@@ -90,30 +90,18 @@ jobs:
           FIX_YAML_PRETTIER: "${{ env.PERFORM_CODEBASE_FIX }}"
           VALIDATE_BASH_EXEC: true
           VALIDATE_BASH: true
+          VALIDATE_CLANG_FORMAT: true
+          VALIDATE_CPP: true
           VALIDATE_GO: true
-          VALIDATE_GO_MODULES: true
           VALIDATE_GITHUB_ACTIONS: true
           VALIDATE_GROOVY: true
           VALIDATE_JSON_PRETTIER: true
           VALIDATE_JSONC_PRETTIER: true
-          VALIDATE_MARKDOWN_PRETTIER: true
+          VALIDATE_MARKDOWN: true
           VALIDATE_PROTOBUF: true
           VALIDATE_PYTHON_BLACK: true
           VALIDATE_YAML_PRETTIER: true
 
-      - name: "super-linter: clang_format lint/fix. No error approach."
-        uses: super-linter/super-linter/slim@e1cb86b6e8d119f789513668b4b30bf17fe1efe4 # v7.2.0 x-release-please-version
-        env:
-          FIX_CLANG_FORMAT: "${{ env.PERFORM_CODEBASE_FIX }}"
-          VALIDATE_CLANG_FORMAT: true
-          DISABLE_ERRORS: true
-
-      - name: "super-linter: cpp-lint. No error approach."
-        uses: super-linter/super-linter/slim@e1cb86b6e8d119f789513668b4b30bf17fe1efe4 # v7.2.0 x-release-please-version
-        env:
-          VALIDATE_CPP: true
-          DISABLE_ERRORS: true
-
       - name: "super-linter: Commit and push linting fixes"
         if: >
           ( github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' ) &&

diff --git a/control-plane-agent/CMakeLists.txt b/control-plane-agent/CMakeLists.txt
@@ -75,7 +75,7 @@ add_custom_target(generate_grpc
 
 # Add a custom target to run all unit tests
 add_custom_target(gotest
-    COMMAND ${GO_EXECUTABLE} test ./...
+    COMMAND ${GO_EXECUTABLE} test -timeout=30s ./...
     WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
     COMMENT "Running Go unit tests..."
     DEPENDS generate_grpc

diff --git a/control-plane-agent/api/proxy/proxy.go b/control-plane-agent/api/proxy/proxy.go
@@ -61,13 +61,21 @@ func (a *API) RegisterMediaProxy(ctx context.Context, in *pb.RegisterMediaProxyR
 		return nil, errors.New("proxy register request")
 	}
 
-	reply := event.PostEventSync(ctx, event.OnRegisterMediaProxy, map[string]interface{}{
-		"sdk_api_port":               in.SdkApiPort,
-		"st2110.dev_port_bdf":        in.St2110Config.DevPortBdf,
-		"st2110.dataplane_ip_addr":   in.St2110Config.DataplaneIpAddr,
-		"rdma.dataplane_ip_addr":     in.RdmaConfig.DataplaneIpAddr,
-		"rdma.dataplane_local_ports": in.RdmaConfig.DataplaneLocalPorts,
-	})
+	params := map[string]interface{}{
+		"sdk_api_port": in.SdkApiPort,
+	}
+
+	if in.St2110Config != nil {
+		params["st2110.dev_port_bdf"] = in.St2110Config.DevPortBdf
+		params["st2110.dataplane_ip_addr"] = in.St2110Config.DataplaneIpAddr
+	}
+
+	if in.RdmaConfig != nil {
+		params["rdma.dataplane_ip_addr"] = in.RdmaConfig.DataplaneIpAddr
+		params["rdma.dataplane_local_ports"] = in.RdmaConfig.DataplaneLocalPorts
+	}
+
+	reply := event.PostEventSync(ctx, event.OnRegisterMediaProxy, params)
 	if reply.Err != nil {
 		logrus.Errorf("Proxy register req err: %v", reply.Err)
 		return nil, reply.Err